Prevent long text from breaking Badges
ClosedPublic
Actions

Authored by chad on Jul 26 2015, 9:37 PM.

Tags

None

Referenced Files

	F14034698: D13730.diff
	Sun, Nov 10, 1:49 AM

	F14019571: D13730.diff
	Tue, Nov 5, 10:48 PM

	F13980403: D13730.id33161.diff
	Sat, Oct 19, 10:25 AM

	F13976386: D13730.diff
	Fri, Oct 18, 2:01 PM

	F13964660: D13730.diff
	Tue, Oct 15, 9:13 PM

	F13964278: D13730.id33175.diff
	Tue, Oct 15, 8:00 PM

	F13964276: D13730.id33161.diff
	Tue, Oct 15, 8:00 PM

	F13964275: D13730.id.diff
	Tue, Oct 15, 8:00 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPd6d37558887b: Prevent long text from breaking Badges

Summary

Put super long text for title and flavor text on badges and resolve breaking issues.

Test Plan

Tested Supercalifragilisticexpialidocious for title and flavor.

Diff Detail

Repository

rP Phabricator

Branch

badges-long-titles

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7412
Build 7864: [Placeholder Plan] Wait for 30 Seconds
Build 7863: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33161.Jul 26 2015, 9:37 PM

chad retitled this revision from to Prevent long text from breaking Badges.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 26 2015, 9:37 PM

epriestley accepted this revision.Jul 27 2015, 2:36 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 27 2015, 2:36 PM

Closed by commit rPd6d37558887b: Prevent long text from breaking Badges (authored by chad, committed by chad). · Explain WhyJul 27 2015, 2:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

phui/

phui-badge.css

5 lines

Diff 33161

View Options

resources/celerity/map.php