Differential D13717

Fix sending mail on Badges
ClosedPublic
Actions

Authored by chad on Jul 26 2015, 4:21 AM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP84b92afe0815: Fix sending mail on Badges

Summary

Hopefully fixes mail issues. Don't have a local way of testing email replies, though.

Test Plan

Comment on a badge, get mail!

Diff Detail

Repository

rP Phabricator

Branch

countdown-feed

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7397
Build 7834: [Placeholder Plan] Wait for 30 Seconds
Build 7833: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33146.Jul 26 2015, 4:21 AM

chad retitled this revision from to Fix sending mail on Badg.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 26 2015, 4:21 AM

chad retitled this revision from Fix sending mail on Badg to Fix sending mail on Badge.Jul 26 2015, 4:51 AM

chad retitled this revision from Fix sending mail on Badge to Fix sending mail on Badges.

seayoung1112 added a subscriber: seayoung1112.Jul 26 2015, 6:16 AM

This comment was removed by seayoung1112.

src/applications/badges/editor/PhabricatorBadgesEditor.php
182	test comment

epriestley accepted this revision.Jul 28 2015, 2:46 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 28 2015, 2:46 PM

Closed by commit rP84b92afe0815: Fix sending mail on Badges (authored by chad, committed by chad). · Explain WhyJul 28 2015, 2:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

editor/

PhabricatorBadgesEditor.php

1 line

Diff 33146

View Options

src/applications/badges/editor/PhabricatorBadgesEditor.php

Fix sending mail on BadgesClosedPublicActions