Page MenuHomePhabricator
Differential D13704

Add commenting to Badges
ClosedPublic
Actions

Authored by chad on Jul 24 2015, 5:41 PM.
Tags
None
Referenced Files
F14013085: D13704.id.diff
Sat, Nov 2, 12:32 AM
F14013084: D13704.id33118.diff
Sat, Nov 2, 12:32 AM
F14013083: D13704.id33117.diff
Sat, Nov 2, 12:32 AM
F14011631: D13704.diff
Fri, Nov 1, 3:59 AM
F14006398: D13704.diff
Mon, Oct 28, 8:23 AM
F13970032: D13704.id33118.diff
Thu, Oct 17, 5:19 AM
F13970031: D13704.id33117.diff
Thu, Oct 17, 5:19 AM
F13965891: D13704.id33117.diff
Wed, Oct 16, 4:53 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Piece of Eight" token, awarded by lpriestley.

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8949: Allow comments on Badges
Commits
Restricted Diffusion Commit
rP10fb011a494d: Add commenting to Badges
Summary

Fixes T8949. Adds the ability to render honors on those who have fought and received badges of distinction and honor.

Test Plan

Write 'asdf'. See 'asdf'.

Diff Detail

Repository
rP Phabricator
Branch
badge-comment
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7382
Build 7804: [Placeholder Plan] Wait for 30 Seconds
Build 7803: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33117.Jul 24 2015, 5:41 PM
chad retitled this revision from to Add commenting to Badges.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8949: Allow comments on Badges.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 24 2015, 5:41 PM
lpriestley awarded a token.Jul 24 2015, 5:41 PM
epriestley accepted this revision.Jul 24 2015, 5:50 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2015, 5:50 PM
Closed by commit rP10fb011a494d: Add commenting to Badges (authored by chad, committed by chad). · Explain WhyJul 24 2015, 5:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33117

View Options

resources/sql/autopatches/20150724.badges.comments.1.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/badges/application/PhabricatorBadgesApplication.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesCommentController.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesViewController.php

Loading...
View Options

src/applications/badges/editor/PhabricatorBadgesEditor.php

Loading...
View Options

src/applications/badges/storage/PhabricatorBadgesTransaction.php

Loading...
View Options

src/applications/badges/storage/PhabricatorBadgesTransactionComment.php

Loading...
Phabricator · Built by Phacility