Remove setObjectName from PHUIHeaderView
ClosedPublic
Actions

Authored by chad on Jul 17 2015, 5:09 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8876: Fix weird object name on Fund Initiatives

Commits

Restricted Diffusion Commit
rPf53128cab4ac: Remove setObjectName from PHUIHeaderView

Summary

This isn't used much (once?) and it's not needed. Fixes T8876

Test Plan

Grep for setObjectName and see if its PHUIHeaderView.

Diff Detail

Repository

rP Phabricator

Branch

obj-name

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7301
Build 7642: [Placeholder Plan] Wait for 30 Seconds
Build 7641: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32991.Jul 17 2015, 5:09 PM

chad retitled this revision from to Remove setObjectName from PHUIHeaderView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8876: Fix weird object name on Fund Initiatives.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 17 2015, 5:09 PM

epriestley accepted this revision.Jul 17 2015, 5:17 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 17 2015, 5:17 PM

Closed by commit rPf53128cab4ac: Remove setObjectName from PHUIHeaderView (authored by chad, committed by chad). · Explain WhyJul 17 2015, 5:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

fund/

controller/

FundInitiativeViewController.php

1 line

view/

phui/

PHUIHeaderView.php

18 lines

Diff 32991

View Options

src/applications/fund/controller/FundInitiativeViewController.php