Make status icons centered in PHUI object list view
ClosedPublic
Actions

Authored by hach-que on Jul 8 2015, 2:01 AM.

Details

Reviewers

chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8789: Status icons are not centred when they have different widths

Commits

Restricted Diffusion Commit
rP8bf347aa9d29: Make status icons centered in PHUI object list view

Summary

Fixes T8789. This makes status icons centered in the PHUI object list view.

Test Plan

Looked at it.

Diff Detail

Repository

rP Phabricator

Branch

phui-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7197
Build 7438: [Placeholder Plan] Wait for 30 Seconds
Build 7437: arc lint + arc unit

Event Timeline

hach-que updated this revision to Diff 32845.Jul 8 2015, 2:01 AM

hach-que retitled this revision from to Make status icons centered in PHUI object list view.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: chad.

hach-que added a task: T8789: Status icons are not centred when they have different widths.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2015, 2:01 AM

Herald added a subscriber: epriestley. · View Herald Transcript

well

I am a CSS noob and probably did this wrong

its not even the right file.

i swear i can hardly breathe right now.

i'll fix it

I'm glad to have provided some entertainment then.

But in all seriousness, I tried search-results.css first, and that didn't seem to apply to pages that had search results on it... given that I was changing how phui-icon-view appears, phui-icon-view.css seemed to be the next most appropriate file to put it in.

Is there a better file that this should be placed in?