Clear "X awarded a token to event Y" stories when visiting event page
ClosedPublic
Actions

Authored by epriestley on Jul 7 2015, 6:55 PM.

Details

Reviewers

btrahan
lpriestley
chad

Commits

Restricted Diffusion Commit
rP308f60a7cd6b: Clear "X awarded a token to event Y" stories when visiting event page

Summary

These detail pages don't have a "pageObjects" configuration, so we don't clear, e.g., token stories correctly when users load them.

Test Plan

Will clear a token story in production.

Diff Detail

Repository

rP Phabricator

Branch

epo

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7185
Build 7415: [Placeholder Plan] Wait for 30 Seconds
Build 7414: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32828.Jul 7 2015, 6:55 PM

epriestley retitled this revision from to Clear "X awarded a token to event Y" stories when visiting event page.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, lpriestley.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 7 2015, 6:55 PM

┏༼ •́ ╭╮ •̀ ༽┓

This revision is now accepted and ready to land.Jul 7 2015, 7:05 PM

Closed by commit rP308f60a7cd6b: Clear "X awarded a token to event Y" stories when visiting event page (authored by epriestley, committed by epriestley). · Explain WhyJul 7 2015, 7:06 PM

This revision was automatically updated to reflect the committed changes.

Er, by "story" I mean "unread notification".

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

controller/

PhabricatorCalendarEventViewController.php

1 line

Diff 32828

View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Clear "X awarded a token to event Y" stories when visiting event pageClosedPublicActions