Page MenuHomePhabricator
Differential D13545

When an install has spaces but a user has no access, roadblock them
ClosedPublic
Actions

Authored by epriestley on Jul 3 2015, 5:44 PM.
Tags
None
Referenced Files
F15283034: D13545.id32727.diff
Tue, Mar 4, 4:46 AM
Unknown Object (File)
Mon, Mar 3, 11:59 PM
Unknown Object (File)
Mon, Mar 3, 11:25 PM
Unknown Object (File)
Tue, Feb 11, 9:36 PM
Unknown Object (File)
Sat, Feb 8, 6:59 PM
Unknown Object (File)
Sat, Feb 8, 6:58 PM
Unknown Object (File)
Sat, Feb 8, 6:58 PM
Unknown Object (File)
Sat, Feb 8, 6:57 PM
View All Files
Subscribers
eadler
epriestley

Details

Reviewers
btrahan
eadler
Maniphest Tasks
T8449: Spaces v1 Errata
Commits
Restricted Diffusion Commit
rPbc22413fa7dd: When an install has spaces but a user has no access, roadblock them
Summary

Ref T8449. If a user doesn't have access to any spaces, most applications just don't work, and they fail in confusing ways.

Just lock users out of everything explicitly up front with a clear message instead of letting them stumble into a big broken mess.

Test Plan

Locked a user out of all spaces, saw error to that effect.

Diff Detail

Repository
rP Phabricator
Branch
space2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7133
Build 7315: [Placeholder Plan] Wait for 30 Seconds
Build 7314: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32727.Jul 3 2015, 5:44 PM
epriestley retitled this revision from to When an install has spaces but a user has no access, roadblock them.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8449: Spaces v1 Errata.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 3 2015, 5:44 PM
eadler accepted this revision.Jul 3 2015, 7:43 PM
eadler added a reviewer: eadler.
eadler added a subscriber: eadler.
eadler added inline comments.
src/applications/spaces/controller/PhabricatorSpacesNoAccessController.php
11–12

this text might be a bit confusing to a new user (whom I'd expect to be most likely not to have any access to spaces) but is technically accurate.

This revision is now accepted and ready to land.Jul 3 2015, 7:43 PM
Closed by commit rPbc22413fa7dd: When an install has spaces but a user has no access, roadblock them (authored by epriestley, committed by epriestley). · Explain WhyJul 3 2015, 8:03 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D13723: Countdown mail support part.Jul 27 2015, 2:33 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
base/
controller/
17 lines
spaces/
controller/
20 lines

Diff 32727

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/spaces/controller/PhabricatorSpacesNoAccessController.php

Loading...
Phabricator · Built by Phacility