Page MenuHomePhabricator

Special-case text sections with empty headers in emails.
AbandonedPublic

Authored by klimek on Jul 2 2015, 12:21 PM.
Tags
None
Referenced Files
F14377382: D13526.id.diff
Sat, Dec 21, 1:28 AM
F14376217: D13526.id32699.diff
Fri, Dec 20, 11:27 PM
Unknown Object (File)
Thu, Dec 19, 7:47 AM
Unknown Object (File)
Tue, Dec 17, 9:05 PM
Unknown Object (File)
Tue, Dec 17, 8:06 PM
Unknown Object (File)
Tue, Dec 17, 7:13 PM
Unknown Object (File)
Wed, Nov 27, 3:45 AM
Unknown Object (File)
Tue, Nov 26, 11:26 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

This allows admins to configure a translation that translates some
section headers like REVISION_SUMMARY to an empty string and have the section
blend into the email naturally.

Putting the patch out there so it's clearer what the size of the change is,
and a decision whether to accept this can be made easier.

Test Plan

Configured empty sections, sent email.

Diff Detail

Repository
rP Phabricator
Branch
allow-empty-header-sections
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7114
Build 7280: [Placeholder Plan] Wait for 30 Seconds
Build 7279: arc lint + arc unit

Event Timeline

klimek retitled this revision from to Special-case text sections with empty headers in emails..
klimek updated this object.
klimek edited the test plan for this revision. (Show Details)
klimek added a reviewer: epriestley.