Page MenuHomePhabricator
Differential D13468

Fix Push Log rendering of query results in redesign
ClosedPublic
Actions

Authored by epriestley on Jun 29 2015, 1:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 4:34 PM
Unknown Object (File)
Mon, Nov 18, 4:21 PM
Unknown Object (File)
Thu, Nov 14, 7:17 AM
Unknown Object (File)
Sun, Nov 10, 2:14 AM
Unknown Object (File)
Wed, Nov 6, 4:46 AM
Unknown Object (File)
Tue, Oct 29, 3:48 PM
Unknown Object (File)
Sun, Oct 27, 9:29 PM
Unknown Object (File)
Oct 26 2024, 9:57 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T8698: Exception when viewing repository push log
Commits
Restricted Diffusion Commit
rPe576ef4bfe2d: Fix Push Log rendering of query results in redesign
Summary

Fixes T8698. This isn't actually a table.

Test Plan

Viewed push log, no more fatal.

Diff Detail

Repository
rP Phabricator
Branch
pushlog
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7040
Build 7133: [Placeholder Plan] Wait for 30 Seconds
Build 7132: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32592.Jun 29 2015, 1:23 PM
epriestley retitled this revision from to Fix Push Log rendering of query results in redesign.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8698: Exception when viewing repository push log.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 29 2015, 1:23 PM
chad accepted this revision.Jun 29 2015, 1:50 PM
chad edited edge metadata.
chad added inline comments.
src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php
112

need to add setCollapsed too to have the table bleed to the edges I think.

This revision is now accepted and ready to land.Jun 29 2015, 1:50 PM
Closed by commit rPe576ef4bfe2d: Fix Push Log rendering of query results in redesign (authored by epriestley, committed by epriestley). · Explain WhyJun 29 2015, 1:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
query/
8 lines

Diff 32592

View Options

src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php

Loading...
Phabricator · Built by Phacility