Paths

Table of Contentst

Differential D13460

Fix Alamanc service paging
ClosedPublic
Actions

Authored by epriestley on Jun 26 2015, 6:50 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8686: Expand Phacility cluster repo and db cluster tiers

Commits

Restricted Diffusion Commit
rP7c3a7f47cdf6: Fix Alamanc service paging

Summary

Ref T8686. This method has the wrong name and calls a nonexistent method on $service.

Test Plan

Set page size to 5, paged locally, hit error, applied changes, got clean paging.

Diff Detail

Repository

rP Phabricator

Branch

squery1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7030
Build 7114: [Placeholder Plan] Wait for 30 Seconds
Build 7113: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32574.Jun 26 2015, 6:50 PM

epriestley retitled this revision from to Fix Alamanc service paging.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8686: Expand Phacility cluster repo and db cluster tiers.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 26 2015, 6:50 PM

I also grepped for other instances of this particular error, but did not locate any.

epriestley mentioned this in T8686: Expand Phacility cluster repo and db cluster tiers.Jun 26 2015, 6:51 PM

btrahan accepted this revision.Jun 26 2015, 10:02 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 26 2015, 10:02 PM

Closed by commit rP7c3a7f47cdf6: Fix Alamanc service paging (authored by epriestley, committed by epriestley). · Explain WhyJun 26 2015, 10:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

query/

AlmanacServiceQuery.php

4 lines

Diff 32574

View Options

src/applications/almanac/query/AlmanacServiceQuery.php

Fix Alamanc service pagingClosedPublicActions