Page MenuHomePhabricator
Differential D13460

Fix Alamanc service paging
ClosedPublic
Actions

Authored by epriestley on Jun 26 2015, 6:50 PM.
Tags
None
Referenced Files
F17946362: D13460.id32574.diff
Thu, Jul 31, 2:17 PM
F17928673: D13460.id.diff
Wed, Jul 30, 4:19 PM
F17917743: D13460.diff
Wed, Jul 30, 12:05 AM
Unknown Object (File)
Jun 5 2025, 7:08 PM
Unknown Object (File)
May 20 2025, 3:10 PM
Unknown Object (File)
May 19 2025, 11:30 PM
Unknown Object (File)
May 6 2025, 5:47 PM
Unknown Object (File)
Apr 26 2025, 12:27 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8686: Expand Phacility cluster repo and db cluster tiers
Commits
Restricted Diffusion Commit
rP7c3a7f47cdf6: Fix Alamanc service paging
Summary

Ref T8686. This method has the wrong name and calls a nonexistent method on $service.

Test Plan

Set page size to 5, paged locally, hit error, applied changes, got clean paging.

Diff Detail

Repository
rP Phabricator
Branch
squery1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7030
Build 7114: [Placeholder Plan] Wait for 30 Seconds
Build 7113: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32574.Jun 26 2015, 6:50 PM
epriestley retitled this revision from to Fix Alamanc service paging.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8686: Expand Phacility cluster repo and db cluster tiers.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 26 2015, 6:50 PM
epriestley added a comment.Jun 26 2015, 6:51 PM

I also grepped for other instances of this particular error, but did not locate any.

epriestley mentioned this in T8686: Expand Phacility cluster repo and db cluster tiers.Jun 26 2015, 6:51 PM
btrahan accepted this revision.Jun 26 2015, 10:02 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 26 2015, 10:02 PM
Closed by commit rP7c3a7f47cdf6: Fix Alamanc service paging (authored by epriestley, committed by epriestley). · Explain WhyJun 26 2015, 10:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
query/
4 lines

Diff 32574

View Options

src/applications/almanac/query/AlmanacServiceQuery.php

Loading...
Phabricator · Built by Phacility