Page MenuHomePhabricator

Conpherence - move crumb-based room edit to widget; other cleanup
ClosedPublic

Authored by btrahan on Jun 25 2015, 10:44 PM.
Tags
None
Referenced Files
F14063041: D13449.diff
Mon, Nov 18, 4:16 PM
F14050268: D13449.diff
Thu, Nov 14, 5:34 PM
F14040730: D13449.diff
Mon, Nov 11, 12:46 PM
F14040595: D13449.id32552.diff
Mon, Nov 11, 11:29 AM
F14023305: D13449.diff
Thu, Nov 7, 12:54 AM
F14022365: D13449.id32557.diff
Wed, Nov 6, 4:53 PM
F13997796: D13449.id32557.diff
Thu, Oct 24, 6:14 AM
F13997335: D13449.diff
Thu, Oct 24, 3:47 AM
Subscribers
Tokens
"Pterodactyl" token, awarded by sshannin.

Details

Summary

We use a non-standard way to invoke the edit dialogue (title, picture, etc) via the crumb. Stop doing that and instead use the widget technology to invoke the dialogue.

This requires making the widget handling code a bit more nuanced as nothing has wanted to pop a dialogue before. I plan to clean this up as I add the action to "Mark as Favorite" to the UI. In particular, I want to stop rendering the un-used DOM and make a workflow-based widget action a property as opposed to something hardcoded. This may be too ambitious depending on how similar these workflows are....

This also updates the ThreadSearchEngine to be a bit more modern. Additionally, go through making some user-facing strings a bit more sensical.

Test Plan

changed settings from conpherence full and durable column successfully.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Conpherence - application cleanup.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added a subscriber: epriestley.
btrahan retitled this revision from Conpherence - application cleanup to Conpherence - move crumb-based room edit to widget; other cleanup.Jun 25 2015, 10:52 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 25 2015, 10:56 PM
This revision was automatically updated to reflect the committed changes.