Page MenuHomePhabricator
Differential D13404

Reduce Lint/Unit rendering duplication
ClosedPublic
Actions

Authored by epriestley on Jun 23 2015, 6:31 PM.
Tags
None
Referenced Files
F13319434: D13404.diff
Thu, Jun 13, 12:37 PM
F13314121: D13404.id.diff
Tue, Jun 11, 4:54 PM
F13311104: D13404.id32471.diff
Tue, Jun 11, 12:51 AM
F13261806: D13404.diff
Mon, May 27, 1:27 AM
F13244293: D13404.diff
Thu, May 23, 4:41 AM
F13240020: D13404.id32471.diff
Wed, May 22, 9:26 AM
F13239585: D13404.id32463.diff
Wed, May 22, 4:44 AM
F13222744: D13404.diff
Sun, May 19, 3:55 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8096: Improve Harbormaster UI/UX (v1)
Commits
Restricted Diffusion Commit
rPb074cdeb4c50: Reduce Lint/Unit rendering duplication
Summary

Ref T8096. No functional changes, just a bit less code.

Test Plan

Viewed some revisions, saw the same stuff as before.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32463.Jun 23 2015, 6:31 PM
epriestley retitled this revision from to Reduce Lint/Unit rendering duplication.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8096: Improve Harbormaster UI/UX (v1).
epriestley added a subscriber: epriestley.
btrahan accepted this revision.Jun 23 2015, 7:38 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2015, 7:38 PM
Closed by commit rPb074cdeb4c50: Reduce Lint/Unit rendering duplication (authored by epriestley, committed by epriestley). · Explain WhyJun 23 2015, 8:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
6 lines
applications/
differential/
customfield/
96 lines
106 lines
98 lines

Diff 32471

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/customfield/DifferentialHarbormasterField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialLintField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialUnitField.php

Loading...
Phabricator · Built by Phacility