Paths

Table of Contentst

Differential D13397

MetaMTA - more progress towards a mail application
ClosedPublic
Actions

Authored by btrahan on Jun 22 2015, 11:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 3:52 PM

	Unknown Object (File)
	Tue, Dec 10, 6:26 PM

	Unknown Object (File)
	Sat, Dec 7, 6:08 AM

	Unknown Object (File)
	Fri, Dec 6, 1:15 PM

	Unknown Object (File)
	Fri, Nov 29, 12:55 PM

	Unknown Object (File)
	Wed, Nov 27, 3:50 AM

	Unknown Object (File)
	Sat, Nov 23, 1:38 PM

	Unknown Object (File)
	Nov 19 2024, 11:03 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T5791: Write Herald rules for outbound mail

Commits

Restricted Diffusion Commit
rPdfef8e2f0757: MetaMTA - more progress towards a mail application

Summary

Ref T5791. This diff does a few things...

Adds code to write recipients to edges on save
Makes Query performance for policy filtering okay-ish
Adds a Search Engine for PhabricatorMetaMTAMail
Adds "working" List Controller
- Inbox and Outbox both work
Adds stub View Controller

Test Plan

ran ./bin/storage upgrade and saw my inbox and outbox start getting data. played with application and saw new entries in inbox and outbox

Diff Detail

Repository

Branch

T5791

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php:7	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 6961
Build 6985: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 32438.Jun 22 2015, 11:49 PM

btrahan added a task: T5791: Write Herald rules for outbound mail.

btrahan retitled this revision from to MetaMTA - more progress towards a mail application.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 22 2015, 11:49 PM

I just made the recipient edge one way; I figured thats all we needed.

epriestley accepted this revision.Jun 23 2015, 12:36 AM

epriestley edited edge metadata.

epriestley added inline comments.

resources/sql/autopatches/20150622.metamta.7.recipient-edge-mig.php
1 ↗	(On Diff #32438)	I'd maybe just drop this since I'm not sure it's worth the downtime.
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
375	Possibly we should write edges to the union of the expanded and un-expanded recipients, so you can search for stuff sent to projects. We could do that later.
1043	This potentially involves queries which will do single gets, so we should maybe load + attach the edges in the Query unconditionally to make this cheap. Not too important for now.

This revision is now accepted and ready to land.Jun 23 2015, 12:36 AM

In D13397#143428, @btrahan wrote:

I just made the recipient edge one way; I figured thats all we needed.

Yeah, I don't see a use for the other half of the edge either.

ACK'ing the comments; thanks!

resources/sql/autopatches/20150622.metamta.7.recipient-edge-mig.php
1 ↗	(On Diff #32438)	Alrighty, i'll rm the script. Was still good ish for development. :D
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
375	will address in this diff.
1043	I'll look at this in a later diff.

remove migration script
add project phids, etc to edges

btrahan updated this object.Jun 23 2015, 6:33 PM

Closed by commit rPdfef8e2f0757: MetaMTA - more progress towards a mail application (authored by btrahan, committed by btrahan). · Explain WhyJun 23 2015, 6:35 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13053: Plans: Mail Tags and Failover.Feb 1 2018, 4:08 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

8 lines

applications/

metamta/

application/

PhabricatorMetaMTAApplication.php

3 lines

controller/

PhabricatorMetaMTAMailListController.php

30 lines

PhabricatorMetaMTAMailViewController.php

10 lines

edge/

PhabricatorMetaMTAMailHasRecipientEdgeType.php

8 lines

query/

PhabricatorMetaMTAMailQuery.php

54 lines

PhabricatorMetaMTAMailSearchEngine.php

112 lines

storage/

PhabricatorMetaMTAMail.php

24 lines

Diff 32464

src/__phutil_library_map__.php

Loading...

src/applications/metamta/application/PhabricatorMetaMTAApplication.php

Loading...

src/applications/metamta/controller/PhabricatorMetaMTAMailListController.php

Loading...

src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php

Loading...

src/applications/metamta/edge/PhabricatorMetaMTAMailHasRecipientEdgeType.php

Loading...

src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php

Loading...

src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php

Loading...

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...