Differential D13356

Show build plan name on Harbormaster plan view controller
ClosedPublic
Actions

Authored by hach-que on Jun 19 2015, 5:29 AM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, Feb 8, 12:50 PM

	Unknown Object (File)
	Sat, Feb 8, 12:49 PM

	Unknown Object (File)
	Sat, Feb 8, 12:49 PM

	Unknown Object (File)
	Sat, Feb 8, 12:48 PM

	Unknown Object (File)
	Sat, Feb 8, 12:48 PM

	Unknown Object (File)
	Mon, Jan 27, 10:57 AM

	Unknown Object (File)
	Fri, Jan 24, 6:33 AM

	Unknown Object (File)
	Fri, Jan 24, 6:33 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8096: Improve Harbormaster UI/UX (v1)

Commits

Restricted Diffusion Commit
rP44dee47c2882: Show build plan name on Harbormaster plan view controller

Summary

Ref T8096. This shows the build plan name on the Harbormaster build plan view controller. Without this, the name is not displayed anywhere on the page when you're viewing a build plan's configuration (which makes things confusing if you're updating a bunch of build plans at once).

Test Plan

Viewed a build plan, saw the build plan name on the page.

Diff Detail

Repository

Branch

show-plan-name

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6870
Build 6892: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 32316.Jun 19 2015, 5:29 AM

hach-que retitled this revision from to Show build plan name on Harbormaster plan view controller.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T8096: Improve Harbormaster UI/UX (v1).

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 19 2015, 5:29 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Sneaking this one on T8096 since it's UI / UX related (it was previously and quite randomly part of D9807).

hach-que mentioned this in D9807: [harbormaster/run-build-plan] Implement build step for running another build plan.Jun 19 2015, 5:40 AM

epriestley accepted this revision.Jun 19 2015, 12:39 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/harbormaster/controller/HarbormasterPlanViewController.php
30	Maybe throw the name in here, too?
44	This one is fine as-is (short for crumbs).

This revision is now accepted and ready to land.Jun 19 2015, 12:39 PM

Show name in title as well

Closed by commit rP44dee47c2882: Show build plan name on Harbormaster plan view controller (authored by hach-que, committed by hach-que). · Explain WhyJun 20 2015, 4:23 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterPlanViewController.php

2 lines

Diff 32316

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Loading...