Closes T8340
Details
- Reviewers
epriestley lpriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8340: Make pretty feed titles for recurring event edits
- Commits
- Restricted Diffusion Commit
rPb1f64d93566f: Adds details to Calendar event feed titles
Verify that calendar event feed titles have more detail that before.
Diff Detail
- Repository
- rP Phabricator
- Branch
- prettyfeedtitles
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 6861 Build 6883: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
All the other transaction feed stories end with a period. We should be consistent.
src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php | ||
---|---|---|
261 | On second thought, maybe this would sound better as, %s set this event to repeat %s? | |
266–269 | The other date-related transaction feed stories don't actually specify the new value, so let's drop it here for consistency. There also might be some peskiness related to formatting and rendering the date, and because we don't actually ever hit this case, we probably want to avoid any uncertainties. Also, this isn't the "end date" of the event (that's something separate). This is the "recurrence end date". | |
452–455 | This should match what is in getTitle as best as it can. So, %s made %s a recurring event. | |
457–461 | For now, this only shows up on event creation, and there is no "change" in that case. Would be more versatile to make this, %s set %s to repeat %s | |
463 | We already have a separate transaction for TYPE_END_DATE and this could be confusing, so we should definitely mention the "recurrence" part. And, as in a previous comment, we don't actually include the new date in other date-related transactions, so let's drop it. |
src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php | ||
---|---|---|
257 | For consistency, just say "%s made this event recurring." instead of "%s has made this event recurring." (that is, no "has"). We don't use the word "has" in other strings (for example: "%s created this revision.", not "%s has created this revision."). | |
261 | This isn't translatable because the second parameter will be an English word like "daily", "weekly", or "monthly". It's also not sufficient to just translate the word fragments separately. In some languages, the rest of the sentence may depend on the word. For example, it's possible that this phrase translates into Spanish most naturally like "repeats on the x", as either "..repetere un la dia." or "...repetere un el mes.", where the use of the article "la" or "el" varies depending on whether the noun "day" or "month" is feminine or masculine (I don't know Spanish and this specific case is probably not correct, but this is a general issue with translating into other languages). To allow translators to translate this string properly, each variant of it needs to be separated out, something like this: switch ($new) { case SomeCalendarClass::SOME_DAILY_CONSTANT: return pht('%s set this event to repeat daily.', ...); case SomeCalendarClass::SOME_MONTHLY_CONSTANT: return pht('%s set this event to repeat monthly.', ...); ... } Then foreign language translators can translate the word and adjust articles appropriately. | |
266 | Drop "has" here, too. | |
457 | Same "daily" issue here. |
Looks great, thanks!
I updated the documentation too, since it was basically impossible to guess the right rules or understand the reasoning before:
https://secure.phabricator.com/book/phabcontrib/article/internationalization/