Differential D13342

Clarify that 'order' is an optional parameter in Conduit API methods
ClosedPublic
Actions

Authored by epriestley on Jun 18 2015, 4:21 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8603: repository.query is not returning required parameter `order`

Commits

Restricted Diffusion Commit
rP90078fe06ea5: Clarify that 'order' is an optional parameter in Conduit API methods

Summary

Fixes T8603. For automatic 'order' parameters provided by infrastructure en route to T7715, clarify that they are optional (we will use the default builtin order for the underlying Query if an order is not provided).

Test Plan

Used web UI to see "optional" hint.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32283.Jun 18 2015, 4:21 PM

epriestley retitled this revision from to Clarify that 'order' is an optional parameter in Conduit API methods.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8603: repository.query is not returning required parameter `order`.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 18 2015, 4:21 PM

btrahan accepted this revision.Jun 18 2015, 7:33 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 18 2015, 7:33 PM

Closed by commit rP90078fe06ea5: Clarify that 'order' is an optional parameter in Conduit API methods (authored by epriestley, committed by epriestley). · Explain WhyJun 18 2015, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

method/

ConduitAPIMethod.php

2 lines

Diff 32295

View Options

src/applications/conduit/method/ConduitAPIMethod.php

Clarify that 'order' is an optional parameter in Conduit API methodsClosedPublicActions