Page MenuHomePhabricator
Differential D13342

Clarify that 'order' is an optional parameter in Conduit API methods
ClosedPublic
Actions

Authored by epriestley on Jun 18 2015, 4:21 PM.
Tags
None
Referenced Files
F14060259: D13342.diff
Mon, Nov 18, 12:15 AM
F14046205: D13342.diff
Wed, Nov 13, 7:18 PM
F14035010: D13342.diff
Sun, Nov 10, 3:29 AM
F14018943: D13342.diff
Tue, Nov 5, 8:39 PM
F13996410: D13342.id.diff
Wed, Oct 23, 8:57 PM
F13984426: D13342.diff
Oct 20 2024, 1:19 PM
F13967378: D13342.id32283.diff
Oct 16 2024, 1:13 PM
Unknown Object (File)
Sep 12 2024, 7:42 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8603: repository.query is not returning required parameter `order`
Commits
Restricted Diffusion Commit
rP90078fe06ea5: Clarify that 'order' is an optional parameter in Conduit API methods
Summary

Fixes T8603. For automatic 'order' parameters provided by infrastructure en route to T7715, clarify that they are optional (we will use the default builtin order for the underlying Query if an order is not provided).

Test Plan

Used web UI to see "optional" hint.

Diff Detail

Repository
rP Phabricator
Branch
order1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6847
Build 6869: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32283.Jun 18 2015, 4:21 PM
epriestley retitled this revision from to Clarify that 'order' is an optional parameter in Conduit API methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8603: repository.query is not returning required parameter `order`.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 18 2015, 4:21 PM
btrahan accepted this revision.Jun 18 2015, 7:33 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 18 2015, 7:33 PM
Closed by commit rP90078fe06ea5: Clarify that 'order' is an optional parameter in Conduit API methods (authored by epriestley, committed by epriestley). · Explain WhyJun 18 2015, 8:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conduit/
method/
2 lines

Diff 32283

View Options

src/applications/conduit/method/ConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility