Differential D13340

Drop Windows-specific SSH code
ClosedPublic
Actions

Authored by hach-que on Jun 18 2015, 2:51 PM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 9:24 AM

	Unknown Object (File)
	Mon, Dec 9, 9:08 PM

	Unknown Object (File)
	Sun, Dec 8, 2:58 AM

	Unknown Object (File)
	Sat, Dec 7, 6:32 AM

	Unknown Object (File)
	Fri, Nov 29, 1:17 PM

	Unknown Object (File)
	Nov 19 2024, 1:20 AM

	Unknown Object (File)
	Nov 14 2024, 9:41 PM

	Unknown Object (File)
	Nov 11 2024, 5:33 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T2015: Implement Drydock

Commits

Restricted Diffusion Commit
rP827aa05a676e: Drop Windows-specific SSH code

Summary

Ref T2015. This code is only relevant when attempting to run commands on a Windows host over SSH. Since SSH on Windows is extremely fragile and hard to maintain, and WinRM is a better long-term solution, drop this code (which will end up being unused when later diffs introduce the WinRM command interface).

Test Plan

This code won't be used when D10495 lands.

Diff Detail

Repository

Branch

drop-windows-ssh

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6843
Build 6865: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 32278.Jun 18 2015, 2:51 PM

hach-que retitled this revision from to Drop Windows-specific SSH code.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T2015: Implement Drydock.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 18 2015, 2:51 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

hach-que mentioned this in D10495: [drydock/core] Use WinRM instead of SSH for Windows hosts.Jun 18 2015, 3:21 PM

hach-que edited edge metadata.Jun 18 2015, 4:11 PM

hach-que added a project: Drydock.

epriestley accepted this revision.Jun 19 2015, 12:17 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 19 2015, 12:17 AM

Closed by commit rP827aa05a676e: Drop Windows-specific SSH code (authored by hach-que, committed by hach-que). · Explain WhyJun 19 2015, 5:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

interface/

command/

DrydockSSHCommandInterface.php

42 lines

Diff 32278

src/applications/drydock/interface/command/DrydockSSHCommandInterface.php

Loading...