Page MenuHomePhabricator

Email Preferences - round out options for Projects and Phriction
ClosedPublic

Authored by btrahan on Jun 16 2015, 9:22 PM.
Tags
None
Referenced Files
F13319287: D13313.diff
Thu, Jun 13, 12:25 PM
F13314829: D13313.id.diff
Wed, Jun 12, 2:35 AM
F13295826: D13313.diff
Thu, Jun 6, 7:47 AM
F13295765: D13313.id32219.diff
Thu, Jun 6, 7:35 AM
F13286846: D13313.diff
Tue, Jun 4, 7:46 AM
F13280522: D13313.id32218.diff
Sun, Jun 2, 6:17 AM
F13273788: D13313.diff
Fri, May 31, 2:40 AM
F13237341: D13313.id32219.diff
Tue, May 21, 1:40 PM
Subscribers
Tokens
"Doubloon" token, awarded by nornagon.

Details

Summary

Fixes T8524, T8550. These were both missing "subscribers" and Phriction was also the only application with no "other".

Test Plan
  • Project
      • set user A to notify only for project subscriber changes
      • made a project with user A
      • subscribed user B to project
      • verified notification sent to user A
      • used ./bin/mail to make sure no mail was sent to user A because "This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences)."
    • Phriction
      • set user A to notify only for phriction document subscriber changes
      • made a document with user A
      • subscribed user B to document
      • verified notification sent to user A
      • used ./bin/mail to make sure no mail was sent to user A because "This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences)."
      • observed option for "other" in email preferences

Diff Detail

Repository
rP Phabricator
Branch
emailprefs
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6811
Build 6833: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Email Preferences - round out options for Projects and Phriction.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2015, 9:23 PM
This revision was automatically updated to reflect the committed changes.