Differential D13264

Show spaces in policy explanation dialogs
ClosedPublic
Actions

Authored by epriestley on Jun 12 2015, 10:44 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8449: Spaces v1 Errata

Commits

Restricted Diffusion Commit
rPc9be5fef2783: Show spaces in policy explanation dialogs

Summary

Ref T8449. When an object is in a space, explain that clearly in the policy description dialog.

Test Plan

Screen Shot 2015-06-12 at 3.41.57 PM.png (1×1 px, 236 KB)

Diff Detail

Repository

rP Phabricator

Branch

pspacedesc

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6712
Build 6734: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32060.Jun 12 2015, 10:44 PM

epriestley retitled this revision from to Show spaces in policy explanation dialogs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8449: Spaces v1 Errata.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 12 2015, 10:44 PM

epriestley mentioned this in T8376: Develop Spaces (v1).Jun 14 2015, 3:19 PM

btrahan accepted this revision.Jun 15 2015, 6:38 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 15 2015, 6:38 PM

Closed by commit rPc9be5fef2783: Show spaces in policy explanation dialogs (authored by epriestley, committed by epriestley). · Explain WhyJun 16 2015, 3:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

policy/

controller/

PhabricatorPolicyExplainController.php

20 lines

Diff 32060

View Options

src/applications/policy/controller/PhabricatorPolicyExplainController.php

Show spaces in policy explanation dialogsClosedPublicActions