Fix an issue where "Send an email to..." rules might be discarded
ClosedPublic
Actions

Authored by epriestley on Jun 11 2015, 12:45 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction

Commits

Restricted Diffusion Commit
rPa06618f87966: Fix an issue where "Send an email to..." rules might be discarded

Summary

Fixes T8464. We could lose the additional users from "Send an email..." rules if Herald did not apply any other transactions to the task.

Test Plan

Destroyed all Herald rules.
Created a single "Send an email to..." rule.
Created a task.
Saw target get an email.

Diff Detail

Repository

rP Phabricator

Branch

heraldsend

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6684
Build 6706: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32018.Jun 11 2015, 12:45 PM

epriestley retitled this revision from to Fix an issue where "Send an email to..." rules might be discarded.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 11 2015, 12:45 PM

chad accepted this revision.Jun 11 2015, 12:46 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Jun 11 2015, 12:46 PM

Closed by commit rPa06618f87966: Fix an issue where "Send an email to..." rules might be discarded (authored by epriestley, committed by epriestley). · Explain WhyJun 11 2015, 12:53 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction.Jun 11 2015, 12:54 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

10 lines

Diff 32018

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Fix an issue where "Send an email to..." rules might be discardedClosedPublicActions