Page MenuHomePhabricator
Differential D13183

Use standard subscribers effects in Herald Adapter for revisions
ClosedPublic
Actions

Authored by epriestley on Jun 6 2015, 1:04 PM.
Tags
None
Referenced Files
F14347955: D13183.diff
Thu, Dec 19, 4:14 AM
Unknown Object (File)
Fri, Dec 13, 11:57 AM
Unknown Object (File)
Fri, Dec 13, 7:57 AM
Unknown Object (File)
Sun, Dec 8, 2:07 PM
Unknown Object (File)
Fri, Dec 6, 10:37 PM
Unknown Object (File)
Fri, Nov 29, 10:30 AM
Unknown Object (File)
Fri, Nov 22, 5:16 PM
Unknown Object (File)
Nov 18 2024, 9:36 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8455: Herald rules with mailing lists are broken after mailing list -> user migration
Commits
Restricted Diffusion Commit
rP9e88ede69d90: Use standard subscribers effects in Herald Adapter for revisions
Summary

Ref T8455. Use standard effects for revisions, instead of a custom effect.

This fixes the major issue (conduit error) in T8455 because the standard effect now performs PHID type filtering.

This retains other behaviors (in particular: not re-CC'ing explicitly removed CCs).

Test Plan
  • With a Herald rule that adds a mailing list as a CC, created a revision before the change and hit the error in T8455. After the change, saw correct behavior.
  • Wrote a normal Herald rule to add CCs and created a revision, saw it fire properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31863.Jun 6 2015, 1:04 PM
epriestley retitled this revision from to Use standard subscribers effects in Herald Adapter for revisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8455: Herald rules with mailing lists are broken after mailing list -> user migration.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 6 2015, 1:04 PM
epriestley added a comment.Jun 6 2015, 1:04 PM

This removes almost all instances of fbid from the codebase.

btrahan accepted this revision.Jun 8 2015, 5:00 PM
btrahan edited edge metadata.

awesometown

This revision is now accepted and ready to land.Jun 8 2015, 5:00 PM
Closed by commit rP9e88ede69d90: Use standard subscribers effects in Herald Adapter for revisions (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 5:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
23 lines
herald/
adapter/
65 lines

Diff 31921

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

Loading...
Phabricator · Built by Phacility