Page MenuHomePhabricator
Differential D13196

Move Repositories to SearchField
ClosedPublic
Actions

Authored by epriestley on Jun 7 2015, 8:25 PM.
Tags
None
Referenced Files
F15416307: D13196.id31936.diff
Thu, Mar 20, 10:28 AM
F15407254: D13196.id.diff
Tue, Mar 18, 4:32 PM
F15360728: D13196.id31886.diff
Tue, Mar 11, 9:48 AM
F15307926: D13196.diff
Thu, Mar 6, 5:41 AM
Unknown Object (File)
Fri, Feb 21, 5:19 PM
Unknown Object (File)
Feb 12 2025, 8:55 PM
Unknown Object (File)
Feb 11 2025, 9:25 PM
Unknown Object (File)
Feb 9 2025, 3:57 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch
T8441: Integrate Spaces into ApplicationSearch
Commits
Restricted Diffusion Commit
rPd4a3706aeeb0: Move Repositories to SearchField
Summary

Ref T8441. Ref T7715. Internalizes setQueryOrder(). Removes appendOrderFieldsToForm().

Test Plan

Used all Repository search fields.

Diff Detail

Repository
rP Phabricator
Branch
spaces10
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6610
Build 6632: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31886.Jun 7 2015, 8:25 PM
epriestley retitled this revision from to Move Repositories to SearchField.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T8441: Integrate Spaces into ApplicationSearch, T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 7 2015, 8:25 PM
btrahan accepted this revision.Jun 8 2015, 6:42 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2015, 6:42 PM
Closed by commit rPd4a3706aeeb0: Move Repositories to SearchField (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 7:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
query/
67 lines
159 lines
search/
engine/
77 lines

Diff 31886

View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
Phabricator · Built by Phacility