Page MenuHomePhabricator
Differential D13193

Support ordering in SearchField
ClosedPublic
Actions

Authored by epriestley on Jun 7 2015, 6:59 PM.
Tags
None
Referenced Files
F15460971: D13193.id31883.diff
Tue, Apr 1, 3:57 AM
F15418261: D13193.id31933.diff
Thu, Mar 20, 10:05 PM
F15411219: D13193.id31883.diff
Wed, Mar 19, 8:55 AM
F15403537: D13193.id.diff
Tue, Mar 18, 3:44 AM
F15401392: D13193.diff
Mon, Mar 17, 5:26 PM
F15401094: D13193.id31883.diff
Mon, Mar 17, 3:40 PM
F15390746: D13193.id31883.diff
Sat, Mar 15, 6:32 AM
F15389245: D13193.diff
Sat, Mar 15, 5:02 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch
T8441: Integrate Spaces into ApplicationSearch
Commits
Restricted Diffusion Commit
rPbf87976d25de: Support ordering in SearchField
Summary

Ref T8441. Ref T7715. Automatically generate a modern "Order" control in ApplicationSearch for engines which fully support SearchField.

Notably, this allows the standard "Order" control to automatically support custom field orders. We do this in Maniphest today, but in an ad-hoc way.

Test Plan

Performed order-by queries in Almanac (Services), Pholio, Files, People, Projects, and Paste.

Diff Detail

Repository
rP Phabricator
Branch
spaces7
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:1235XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 6607
Build 6629: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31883.Jun 7 2015, 6:59 PM
epriestley retitled this revision from to Support ordering in SearchField.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T8441: Integrate Spaces into ApplicationSearch, T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 7 2015, 6:59 PM
btrahan accepted this revision.Jun 8 2015, 6:37 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2015, 6:37 PM
Closed by commit rPbf87976d25de: Support ordering in SearchField (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 7:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31883

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/query/AlmanacServiceQuery.php

Loading...
View Options

src/applications/almanac/query/AlmanacServiceSearchEngine.php

Loading...
View Options

src/applications/files/query/PhabricatorFileQuery.php

Loading...
View Options

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
View Options

src/applications/paste/query/PhabricatorPasteQuery.php

Loading...
View Options

src/applications/paste/query/PhabricatorPasteSearchEngine.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleSearchEngine.php

Loading...
View Options

src/applications/pholio/query/PholioMockQuery.php

Loading...
View Options

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectQuery.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchOrderField.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility