Differential D13189

Move Projects to SearchFields
ClosedPublic
Actions

Authored by epriestley on Jun 7 2015, 4:25 PM.

Tags

None

Referenced Files

	F14047875: D13189.diff
	Thu, Nov 14, 5:35 AM

	F14015710: D13189.id31879.diff
	Sun, Nov 3, 11:45 PM

	F14007917: D13189.id.diff
	Tue, Oct 29, 12:59 PM

	F13997940: D13189.diff
	Thu, Oct 24, 6:55 AM

	F13995090: D13189.id.diff
	Wed, Oct 23, 10:34 AM

	F13988239: D13189.diff
	Mon, Oct 21, 2:10 PM

	F13959979: D13189.id.diff
	Oct 14 2024, 9:30 PM

	F13959009: D13189.id31879.diff
	Oct 14 2024, 5:22 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch
T8441: Integrate Spaces into ApplicationSearch

Commits

Restricted Diffusion Commit
rPc8b866a9569a: Move Projects to SearchFields

Summary

Ref T8441. Ref T7715. This is mostly about getting SearchFields + CustomFields working.

(This includes a couple of SearchFields which aren't used quite yet.)

Test Plan

Used all search controls.
Defined custom fields and searched for them.
Created an old saved search which searches on custom fields on master, switched to this patch, search worked exaclty as written.

Diff Detail

Repository

Branch

spaces4

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/search/engine/PhabricatorApplicationSearchEngine.php:1120	XHP16	TODO Comment
Advice	src/applications/search/field/PhabricatorSearchCustomFieldProxyField.php:38	XHP16	TODO Comment

Unit

No Test Coverage

Build Status

Buildable 6603
Build 6625: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31879.Jun 7 2015, 4:25 PM

epriestley retitled this revision from to Move Projects to SearchFields.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T8441: Integrate Spaces into ApplicationSearch, T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 7 2015, 4:25 PM

btrahan accepted this revision.Jun 8 2015, 6:26 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 8 2015, 6:26 PM

Closed by commit rPc8b866a9569a: Move Projects to SearchFields (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 7:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

10 lines

applications/

project/

query/

PhabricatorProjectSearchEngine.php

180 lines

search/

engine/

PhabricatorApplicationSearchEngine.php

32 lines

field/

PhabricatorSearchCustomFieldProxyField.php

58 lines

PhabricatorSearchDatasourceField.php

17 lines

PhabricatorSearchField.php

4 lines

PhabricatorSearchOwnersField.php

18 lines

PhabricatorSearchSelectField.php

30 lines

PhabricatorSearchTextField.php

18 lines

PhabricatorSearchTokenizerField.php

40 lines

PhabricatorSearchUsersField.php

43 lines

Diff 31879

src/__phutil_library_map__.php

Loading...

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...

src/applications/search/field/PhabricatorSearchCustomFieldProxyField.php

Loading...

src/applications/search/field/PhabricatorSearchDatasourceField.php

Loading...

src/applications/search/field/PhabricatorSearchField.php

Loading...

src/applications/search/field/PhabricatorSearchOwnersField.php

Loading...

src/applications/search/field/PhabricatorSearchSelectField.php

Loading...

src/applications/search/field/PhabricatorSearchTextField.php

Loading...

src/applications/search/field/PhabricatorSearchTokenizerField.php

Loading...

src/applications/search/field/PhabricatorSearchUsersField.php

Loading...