Differential D13182

Use standard subscribers effects in Herald Adapter for tasks
ClosedPublic
Actions

Authored by epriestley on Jun 6 2015, 12:55 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8455: Herald rules with mailing lists are broken after mailing list -> user migration

Commits

Restricted Diffusion Commit
rP1e918eecfaab: Use standard subscribers effects in Herald Adapter for tasks

Summary

Ref T8455. Use the standard effect in task rules, instead of a custom effect.

Test Plan

Wrote a Maniphest CC rule, updated a task, saw rule activate properly.

Diff Detail

Repository

rP Phabricator

Branch

hcc6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6591
Build 6613: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31862.Jun 6 2015, 12:55 PM

epriestley retitled this revision from to Use standard subscribers effects in Herald Adapter for tasks.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 6 2015, 12:55 PM

btrahan accepted this revision.Jun 8 2015, 4:59 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 8 2015, 4:59 PM

Closed by commit rP1e918eecfaab: Use standard subscribers effects in Herald Adapter for tasks (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 5:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldManiphestTaskAdapter.php

20 lines

maniphest/

editor/

ManiphestTransactionEditor.php

7 lines

Diff 31862

View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php