Page MenuHomePhabricator
Differential D13176

Stop threading handles through the CustomField + ApplicationSearch pipeline
ClosedPublic
Actions

Authored by epriestley on Jun 5 2015, 10:58 PM.
Tags
None
Referenced Files
F14350506: D13176.diff
Thu, Dec 19, 7:01 AM
Unknown Object (File)
Tue, Dec 17, 7:45 AM
Unknown Object (File)
Thu, Dec 12, 5:41 PM
Unknown Object (File)
Wed, Dec 11, 2:22 PM
Unknown Object (File)
Wed, Dec 11, 1:45 AM
Unknown Object (File)
Tue, Dec 10, 5:25 AM
Unknown Object (File)
Sun, Dec 8, 10:55 PM
Unknown Object (File)
Thu, Dec 5, 3:32 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch
T8441: Integrate Spaces into ApplicationSearch
Commits
Restricted Diffusion Commit
rPecc4c531c9cb: Stop threading handles through the CustomField + ApplicationSearch pipeline
Summary

Ref T8441. Ref T7715.

  • These are obsolete after the Viewer/HandlePool changes.
  • These are unused after the typeahead parameterization changes.
Test Plan

grep, poked around.

Diff Detail

Repository
rP Phabricator
Branch
spaces3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6582
Build 6604: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31852.Jun 5 2015, 10:58 PM
epriestley retitled this revision from to Stop threading handles through the CustomField + ApplicationSearch pipeline.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T8441: Integrate Spaces into ApplicationSearch, T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 5 2015, 10:58 PM
btrahan accepted this revision.Jun 6 2015, 8:00 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2015, 8:00 PM
epriestley updated this revision to Diff 31875.Jun 7 2015, 2:31 PM
epriestley edited edge metadata.
  • Remove one more @param doc.
Closed by commit rPecc4c531c9cb: Stop threading handles through the CustomField + ApplicationSearch pipeline (authored by epriestley, committed by epriestley). · Explain WhyJun 7 2015, 2:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31852

View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php

Loading...
Phabricator · Built by Phacility