Begin modularizing fields in SearchEngines
ClosedPublic
Actions

Authored by epriestley on Jun 5 2015, 4:06 PM.

Details

Reviewers

Maniphest Tasks

Commits

Summary

Ref T8441. Ref T7715. Add a layer of indirection to fields in search engines. This will allow us to:

Simplify SearchEngine code, which has collected a lot of duplication around expressing what is effectively field types.
Automatically add fields like "Spaces" and "Projects" (primary driver for T8441).
Reorder or hide fields (not sure if we really want to do this, but it seems plausible, and this will let us play around with it, at least).
Drive Conduit Query methods via SearchEngines, so the same code specifies both the search UI and the application.query endpoint (primary driver in T7715).

Test Plan

Searched for stuff in Paste, everything behaved exaclty like it used to (except that I removed the "no language" checkbox, which seemed like fluff from a bygone era).
Searched for stuff in other applications, saw no changes.
Hit date field errors.
Used query strings to specify values.

Repository

rP Phabricator

Branch

spaces9

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/search/field/PhabricatorSearchField.php:212	XHP16	TODO Comment
Advice	src/applications/search/field/PhabricatorSearchUsersField.php:11	XHP16	TODO Comment

Unit

No Test Coverage

Build Status

Buildable 6572
Build 6594: [Placeholder Plan] Wait for 30 Seconds

epriestley retitled this revision from to Begin modularizing fields in SearchEngines.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added inline comments.

src/applications/search/field/PhabricatorSearchUsersField.php
16	This stuff is copied ~verbatim from SearchEngine, but the idea is that this will eventually be the new copy of it, instead of SearchEngine gradually growing a thousand different `readValuesOfTypeXFromRequest()`.