Page MenuHomePhabricator

Slightly modernize NuanceSource
ClosedPublic

Authored by epriestley on Jun 5 2015, 2:56 AM.
Tags
None
Referenced Files
F14389379: D13161.diff
Sat, Dec 21, 5:32 PM
Unknown Object (File)
Sun, Dec 15, 4:53 PM
Unknown Object (File)
Thu, Dec 12, 7:45 PM
Unknown Object (File)
Wed, Dec 4, 5:15 PM
Unknown Object (File)
Wed, Dec 4, 5:30 AM
Unknown Object (File)
Wed, Nov 27, 3:39 AM
Unknown Object (File)
Tue, Nov 26, 7:59 PM
Unknown Object (File)
Fri, Nov 22, 5:10 PM
Subscribers
Tokens
"Piece of Eight" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
T8434: Accommodate the "Security" workflow
Commits
Restricted Diffusion Commit
rP837e6b5ca757: Slightly modernize NuanceSource
Summary

Ref T8434. Minor cleanup/modernization. I made type selection modal (like Herald, Auth, etc) so we can render the form on the next screen based on the type.

Screen Shot 2015-06-04 at 7.56.14 PM.png (819×1 px, 116 KB)

Test Plan

Created a new source, edited an existing source.

Diff Detail

Repository
rP Phabricator
Branch
nuance2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6558
Build 6580: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Slightly modernize NuanceSource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2015, 5:36 PM
This revision was automatically updated to reflect the committed changes.