Ref T2896, Make cancel/reinstate child/ghost/recurring events work
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8368: Navigating to a deprecated instance of a ghost recurring event should display user-friendly messaging.
Restricted Maniphest Task - Commits
- Restricted Diffusion Commit
rPe4c38bb9938a: DRAFT - Make cancel/reinstate child/ghost/recurring events work
Cancel/reinstate child/ghost/recurring events.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendarcancelchild
- Lint
Lint Warnings Severity Location Code Message Warning src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php:72 TXT3 Line Too Long - Unit
Tests Passed - Build Status
Buildable 6532 Build 6554: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Since we now check if there is a corresponding actual event for any ghost event we view, no longer any need to check the same thing when cancelling/resintating.
| src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php | ||
|---|---|---|
| 118 | Is this the same as createEventFromGhost()? Can we share the code? | |
| src/applications/calendar/controller/PhabricatorCalendarEventEditorController.php | ||
| 3 ↗ | (On Diff #31787) | Instead of making this final, make it abstract, then extend the Cancel and Edit controllers from it. Then call $this->createEventFromGhost() (for example) instead of PhabricatorCalendarEventEditController::createEventFromGhost(). This will let the methods be protected instead of public. Actually, since there's a call from ViewController too, maybe it's easiest to just move these methods into the base class PhabricatorCalendarController. |
| src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php | ||
|---|---|---|
| 45 | that cancelGhostEvent method was wrong. It didn't actually cancel anything, and it returned a redirect, which is not useful here. | |