Page MenuHomePhabricator
Differential D13130

Fix some minor Spaces method visibility issues
ClosedPublic
Actions

Authored by epriestley on Jun 2 2015, 10:28 PM.
Tags
None
Referenced Files
F17854178: D13130.diff
Sun, Jul 27, 2:46 PM
F17673997: D13130.diff
Sun, Jul 13, 6:18 AM
Unknown Object (File)
Thu, Jul 3, 8:35 AM
Unknown Object (File)
Sun, Jun 29, 9:12 PM
Unknown Object (File)
Sun, Jun 29, 7:51 PM
Unknown Object (File)
Sat, Jun 28, 1:28 PM
Unknown Object (File)
Jun 17 2025, 11:24 AM
Unknown Object (File)
May 29 2025, 8:34 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8377: Build the core "Spaces" Application
Commits
Restricted Diffusion Commit
rP02f0c099fa25: Fix some minor Spaces method visibility issues
Summary

Ref T8377. These were picked up by tests.

Test Plan

arc unit --everything

Diff Detail

Repository
rP Phabricator
Branch
mlist7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6484
Build 6506: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31698.Jun 2 2015, 10:28 PM
epriestley retitled this revision from to Fix some minor Spaces method visibility issues.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8377: Build the core "Spaces" Application.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 2 2015, 10:28 PM
btrahan accepted this revision.Jun 3 2015, 11:08 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2015, 11:08 PM
Closed by commit rP02f0c099fa25: Fix some minor Spaces method visibility issues (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2015, 1:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
spaces/
controller/
2 lines
query/
2 lines
storage/
2 lines

Diff 31698

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/spaces/controller/PhabricatorSpacesListController.php

Loading...
View Options

src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php

Loading...
View Options

src/applications/spaces/storage/PhabricatorSpacesNamespace.php

Loading...
Phabricator · Built by Phacility