Paths

Table of Contentst

Differential D13108

Edit link of an exception to a ghost event should not create new event
ClosedPublic
Actions

Authored by lpriestley on Jun 2 2015, 2:34 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8382: The edit link of an exception to a ghost event should not create a new event.

Commits

Restricted Diffusion Commit
rPb576cef71006: Edit link of an exception to a ghost event should not create new event

Summary

Fixes T8382, Edit link of an exception to a ghost event should not create new event

Test Plan

Create recurring event, open ghost, edit, save, edit again. Should edit event created after first edit, not new event.

Diff Detail

Repository

rP Phabricator

Branch

calendareditinstance

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6461
Build 6483: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 31648.Jun 2 2015, 2:34 AM

lpriestley retitled this revision from to Edit link of an exception to a ghost event should not create new event.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8382: The edit link of an exception to a ghost event should not create a new event..

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2015, 2:34 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jun 2 2015, 2:13 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
137–139	Doesn't `$event->getIsGhostEvent()` imply these other two?
153	Doesn't `!$event->getIsRecurring()` imply `!$event->getIsGhostEvent()`?

This revision is now accepted and ready to land.Jun 2 2015, 2:13 PM

epriestley added inline comments.Jun 2 2015, 2:13 PM

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
154	Oh, doesn't `$event->getInstanceOfEventPHID()` imply `$event->getIsRecurring()`?

Simplifying conditions for figuring out edit label on recurring events

Closed by commit rPb576cef71006: Edit link of an exception to a ghost event should not create new event (authored by lpriestley, committed by lpriestley). · Explain WhyJun 2 2015, 2:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

controller/

PhabricatorCalendarEventViewController.php

27 lines

Diff 31670

View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Edit link of an exception to a ghost event should not create new eventClosedPublicActions