Page MenuHomePhabricator

Edit link of an exception to a ghost event should not create new event
ClosedPublic

Authored by lpriestley on Jun 2 2015, 2:34 AM.
Tags
None
Referenced Files
F15514759: D13108.id31671.diff
Fri, Apr 18, 5:04 AM
F15503099: D13108.id31671.diff
Mon, Apr 14, 6:50 AM
F15500266: D13108.id31648.diff
Sun, Apr 13, 5:09 PM
F15499092: D13108.id.diff
Sun, Apr 13, 2:37 PM
F15496955: D13108.id31670.diff
Sun, Apr 13, 8:59 AM
F15491798: D13108.diff
Sat, Apr 12, 7:40 AM
F15484539: D13108.id31648.diff
Wed, Apr 9, 6:52 PM
F15459036: D13108.id31670.diff
Mon, Mar 31, 9:15 AM
Subscribers

Details

Summary

Fixes T8382, Edit link of an exception to a ghost event should not create new event

Test Plan

Create recurring event, open ghost, edit, save, edit again. Should edit event created after first edit, not new event.

Diff Detail

Repository
rP Phabricator
Branch
calendareditinstance
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6444
Build 6466: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley retitled this revision from to Edit link of an exception to a ghost event should not create new event.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
138–139

Doesn't $event->getIsGhostEvent() imply these other two?

151

Doesn't !$event->getIsRecurring() imply !$event->getIsGhostEvent()?

This revision is now accepted and ready to land.Jun 2 2015, 2:13 PM
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
152

Oh, doesn't $event->getInstanceOfEventPHID() imply $event->getIsRecurring()?

lpriestley edited edge metadata.

Simplifying conditions for figuring out edit label on recurring events

This revision was automatically updated to reflect the committed changes.