Page MenuHomePhabricator
Differential D13076

Increase CSS specificity on Inline Comment Summary
ClosedPublic
Actions

Authored by chad on May 30 2015, 7:56 PM.
Tags
None
Referenced Files
F14048715: D13076.diff
Thu, Nov 14, 9:16 AM
F14044478: D13076.id.diff
Tue, Nov 12, 4:47 PM
F14041380: D13076.diff
Mon, Nov 11, 6:06 PM
F14027674: D13076.diff
Fri, Nov 8, 8:40 AM
F14012912: D13076.id.diff
Fri, Nov 1, 8:51 PM
F14008640: D13076.diff
Wed, Oct 30, 2:49 AM
F13998785: D13076.diff
Thu, Oct 24, 11:09 AM
F13977866: D13076.id31567.diff
Fri, Oct 18, 8:24 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8354: Inline table cell text doesn't wrap in diff's timeline view
Commits
Restricted Diffusion Commit
rP9708f68e585a: Increase CSS specificity on Inline Comment Summary
Summary

Fixes T8354. Adds a class to each th and td for specificity.

Test Plan

Write a large table as an inline comment, see it wraps property on smaller screens.

Diff Detail

Repository
rP Phabricator
Branch
table-dolumn
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6373
Build 6395: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 31543.May 30 2015, 7:56 PM
chad retitled this revision from to Increase CSS specificity on Inline Comment Summary.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8354: Inline table cell text doesn't wrap in diff's timeline view.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 30 2015, 7:56 PM
epriestley accepted this revision.May 31 2015, 1:43 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 31 2015, 1:43 PM
Closed by commit rP9708f68e585a: Increase CSS specificity on Inline Comment Summary (authored by chad, committed by chad). · Explain WhyMay 31 2015, 3:37 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.May 16 2017, 4:55 PM

Were these supposed to be "column", not "dolumn"?

chad added a comment.May 16 2017, 4:56 PM

no.

th = table header
tr = table row
td = table dolumn

epriestley added a comment.May 16 2017, 4:56 PM

oh of course silly me

chad added a comment.May 16 2017, 4:56 PM

im ded

epriestley added a comment.May 16 2017, 4:57 PM

sorry it took me 2 years to get the joke

chad added a comment.May 16 2017, 4:58 PM

it is nice to know i used to have a sense of humor!

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
infrastructure/
diff/
view/
11 lines
webroot/
rsrc/
css/
application/
diff/
4 lines

Diff 31543

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/view/PhabricatorInlineSummaryView.php

Loading...
View Options

webroot/rsrc/css/application/diff/inline-comment-summary.css

Loading...
Phabricator · Built by Phacility