Fixes T8304, Multi-day events should be correctly calculated for new js layout
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8304: New JS layout rules for Calendar events get events which start before 12:00 AM wrong
- Commits
- Restricted Diffusion Commit
rPe4c991469703: Multi-day events should be correctly calculated for new js layout
A day with events starting before midnight of the displayed day should be correctly placed and fitted for day view.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendarfixmultiday
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 6268 Build 6290: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/infrastructure/time/PhabricatorTime.php | ||
|---|---|---|
| 75–79 | Might be reasonable to just add this to PhabricatorUser, instead, if you want: $datetime = $viewer->getDateTimeFromEpoch($epoch); | |
| src/infrastructure/time/PhabricatorTime.php | ||
|---|---|---|
| 75–79 | Unless you feel strongly about this, it makes more sense in PhabricatorTime, to me, because it's a time conversion, really, and that belongs in a time class of some sort (from where I sit). I, personally, don't mind passing in an extra param. | |