Differential D12980

Swapping out foreach out of behavior
ClosedPublic
Actions

Authored by lpriestley on May 22 2015, 9:29 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8300: Day view should implement a a Javelin behavior

Commits

Restricted Diffusion Commit
rP04584131f791: Swapping out foreach out of behavior

Summary

Ref T8300, swapping out foreach out of behavior

Test Plan

no user facing changes

Diff Detail

Repository

rP Phabricator

Branch

calendardayjsforeach

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6220
Build 6241: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 31285.May 22 2015, 9:29 PM

lpriestley retitled this revision from to Swapping out foreach out of behavior.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8300: Day view should implement a a Javelin behavior.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 22 2015, 9:29 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Kicking the JX.log's

epriestley accepted this revision.May 22 2015, 9:41 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 22 2015, 9:41 PM

Closed by commit rP04584131f791: Swapping out foreach out of behavior (authored by lpriestley, committed by lpriestley). · Explain WhyMay 22 2015, 9:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

js/

application/

calendar/

behavior-day-view.js

32 lines

Diff 31285

View Options

webroot/rsrc/js/application/calendar/behavior-day-view.js

Swapping out foreach out of behaviorClosedPublicActions