Differential D12978

First step towards a Javelin behavior for Calendar day view
ClosedPublic
Actions

Authored by lpriestley on May 22 2015, 8:13 PM.

Tags

None

Referenced Files

	F15579458: D12978.id31286.diff
	Wed, May 7, 12:19 AM

	F15574023: D12978.id.diff
	Mon, May 5, 11:11 PM

	F15558103: D12978.id31283.diff
	Tue, Apr 29, 1:03 AM

	F15553718: D12978.id31282.diff
	Mon, Apr 28, 3:23 AM

	F15550620: D12978.id31286.diff
	Sun, Apr 27, 12:43 PM

	F15548015: D12978.id.diff
	Sat, Apr 26, 9:27 PM

	F15541394: D12978.diff
	Fri, Apr 25, 11:40 AM

	F15514298: D12978.id31286.diff
	Fri, Apr 18, 1:29 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8300: Day view should implement a a Javelin behavior

Commits

Restricted Diffusion Commit
rP8166f25c0d07: First step towards a Javelin behavior for Calendar day view

Summary

Ref T8300, First step towards a Javelin behavior for Calendar day view

Test Plan

No user facing changes.

Diff Detail

Repository

Branch

calendardayviewjsport

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/view/phui/calendar/PHUICalendarDayView.php:111	XHP5	Use of Undeclared Variable
Warning	webroot/rsrc/js/application/calendar/behavior-day-view.js:1	JAVELIN5	`javelinsymbols` Not In Path
Warning	webroot/rsrc/js/application/calendar/behavior-day-view.js:7	W098	JSHintW098
Warning	webroot/rsrc/js/application/calendar/behavior-day-view.js:10	W098	JSHintW098
Warning	webroot/rsrc/js/application/calendar/behavior-day-view.js:12	W003	JSHintW003
Warning	webroot/rsrc/js/application/calendar/behavior-day-view.js:31	W014	JSHintW014
Warning	webroot/rsrc/js/application/calendar/behavior-day-view.js:42	W117	JSHintW117
Warning	webroot/rsrc/js/application/calendar/behavior-day-view.js:43	W117	JSHintW117
Warning	webroot/rsrc/js/application/calendar/behavior-day-view.js:44	W117	JSHintW117

Unit

Tests Passed

Build Status

Buildable 6217
Build 6238: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 31282.May 22 2015, 8:13 PM

lpriestley retitled this revision from to First step towards a Javelin behavior for Calendar day view.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8300: Day view should implement a a Javelin behavior.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 22 2015, 8:13 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Some lint concerns addressed

This revision is now accepted and ready to land.May 22 2015, 8:28 PM

Closed by commit rP8166f25c0d07: First step towards a Javelin behavior for Calendar day view (authored by lpriestley, committed by lpriestley). · Explain WhyMay 22 2015, 9:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

src/

view/

phui/

calendar/

PHUICalendarDayView.php

24 lines

webroot/

rsrc/

js/

application/

calendar/

behavior-day-view.js

50 lines

	behavior-event-all-day.js
	event-all-day.js

16 lines

event-all-day.js

Diff 31282

resources/celerity/map.php

Loading...

src/view/phui/calendar/PHUICalendarDayView.php

Loading...

webroot/rsrc/js/application/calendar/behavior-day-view.js

Loading...

webroot/rsrc/js/application/calendar/behavior-event-all-day.js

Loading...

webroot/rsrc/js/application/calendar/event-all-day.js

Loading...