Paths

Table of Contentst

Differential D12949

Fully remove all the public-create-mail settings
ClosedPublic
Actions

Authored by epriestley on May 20 2015, 2:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 7:12 AM

	Unknown Object (File)
	Thu, Dec 19, 4:08 AM

	Unknown Object (File)
	Thu, Dec 12, 9:05 PM

	Unknown Object (File)
	Tue, Nov 26, 8:11 PM

	Unknown Object (File)
	Fri, Nov 22, 5:23 PM

	Unknown Object (File)
	Nov 18 2024, 9:36 AM

	Unknown Object (File)
	Nov 13 2024, 4:09 PM

	Unknown Object (File)
	Nov 10 2024, 6:02 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T5703: Simplify amount of domain configuration

Commits

Restricted Diffusion Commit
rPf99c7beb90fd: Fully remove all the public-create-mail settings

Summary

Fixes T5703. These have been unused in production for a while and the new stuff seems good.

Test Plan

Mostly grep.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31186.May 20 2015, 2:13 PM

epriestley retitled this revision from to Fully remove all the public-create-mail settings.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5703: Simplify amount of domain configuration.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 20 2015, 2:13 PM

epriestley added inline comments.May 20 2015, 2:14 PM

src/applications/maniphest/controller/ManiphestTaskEditController.php
688–689	I just got rid of this -- in a world with multiple inbound addresses, installs need to document and define their use anyway. We have general feature discovery of inbound mail available in "Help > Email Commands" now, too.

btrahan accepted this revision.May 20 2015, 8:48 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 20 2015, 8:48 PM

Closed by commit rPf99c7beb90fd: Fully remove all the public-create-mail settings (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2015, 9:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorExtraConfigSetupCheck.php

9 lines

files/

config/

PhabricatorFilesConfigOptions.php

14 lines

maniphest/

config/

PhabricatorManiphestConfigOptions.php

51 lines

controller/

ManiphestTaskEditController.php

15 lines

paste/

config/

PhabricatorPasteConfigOptions.php

14 lines

Diff 31206

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...

src/applications/files/config/PhabricatorFilesConfigOptions.php

Loading...

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

Loading...

src/applications/maniphest/controller/ManiphestTaskEditController.php

Loading...

src/applications/paste/config/PhabricatorPasteConfigOptions.php

Loading...