Page MenuHomePhabricator
Differential D12953

Time control typeaheads.
ClosedPublic
Actions

Authored by lpriestley on May 20 2015, 4:12 PM.
Tags
None
Referenced Files
F15310063: D12953.diff
Thu, Mar 6, 8:02 AM
Unknown Object (File)
Tue, Feb 25, 8:53 PM
Unknown Object (File)
Tue, Feb 25, 8:53 PM
Unknown Object (File)
Tue, Feb 11, 9:13 PM
Unknown Object (File)
Mon, Feb 10, 6:17 PM
Unknown Object (File)
Sat, Feb 8, 4:47 AM
Unknown Object (File)
Sat, Feb 8, 4:47 AM
Unknown Object (File)
Sat, Feb 8, 4:47 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8031: Set better start and end time defaults for new Calendar events.
Commits
Restricted Diffusion Commit
rP6b1d13bfaf3d: Time control typeaheads.
Summary

Ref T8031, Time control typeaheads

Test Plan

Edit an event, type '3', typeahead should suggest, '3:00 AM', '3:30 AM', '3:00 PM', '3:30 PM'.

Diff Detail

Repository
rP Phabricator
Branch
calendartimecontroltypeahead
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6157
Build 6178: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 31192.May 20 2015, 4:12 PM
lpriestley retitled this revision from to Time control typeaheads..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added reviewers: epriestley, chad.
lpriestley added a task: T8031: Set better start and end time defaults for new Calendar events..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 20 2015, 4:12 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 20 2015, 4:20 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/view/form/control/AphrontFormDateControl.php
385–388

If you type "1", this might sort "1 AM" before "12 AM" now, which is maybe-questionable?

This revision is now accepted and ready to land.May 20 2015, 4:20 PM
lpriestley added inline comments.May 20 2015, 4:23 PM
src/view/form/control/AphrontFormDateControl.php
385–388

Lolz. I forgot 12 altogether, huh.

lpriestley updated this revision to Diff 31193.May 20 2015, 4:34 PM
lpriestley edited edge metadata.

Adding 12 back in the mix

Closed by commit rP6b1d13bfaf3d: Time control typeaheads. (authored by lpriestley, committed by lpriestley). · Explain WhyMay 20 2015, 4:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
28 lines
src/
view/
form/
control/
37 lines
webroot/
rsrc/
css/
phui/
15 lines
externals/
javelin/
lib/
control/
typeahead/
source/
8 lines
js/
core/
36 lines

Diff 31192

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/AphrontFormDateControl.php

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
View Options

webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js

Loading...
View Options

webroot/rsrc/js/core/behavior-time-typeahead.js

Loading...
Phabricator · Built by Phacility