Page MenuHomePhabricator
Differential D12916

Mobile day view should display event list, not day table
ClosedPublic
Actions

Authored by lpriestley on May 18 2015, 10:39 PM.
Tags
None
Referenced Files
F14062682: D12916.diff
Mon, Nov 18, 1:39 PM
F14049392: D12916.diff
Thu, Nov 14, 12:53 PM
F14036799: D12916.diff
Sun, Nov 10, 12:09 PM
F14036028: D12916.id31072.diff
Sun, Nov 10, 8:17 AM
F14029544: D12916.id31073.diff
Fri, Nov 8, 8:47 PM
F14021876: D12916.diff
Wed, Nov 6, 1:12 PM
F14008577: D12916.diff
Wed, Oct 30, 1:26 AM
F13984410: D12916.id31072.diff
Sun, Oct 20, 1:12 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8178: Calendar day view should show day view above the event preview sidebar on mobile.
Commits
Restricted Diffusion Commit
rPec759ef46f17: Mobile day view should display event list, not day table
Summary

Closes T8178, Mobile day view should display event list, not day table

Test Plan

Open day view on a device, observe that day table is hidden.

Diff Detail

Repository
rP Phabricator
Branch
calendardaydevice
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6090
Build 6110: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 31072.May 18 2015, 10:39 PM
lpriestley retitled this revision from to Mobile day view should display event list, not day table.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added reviewers: epriestley, chad.
lpriestley added a task: T8178: Calendar day view should show day view above the event preview sidebar on mobile..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 18 2015, 10:39 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 31073.May 18 2015, 10:41 PM
lpriestley edited edge metadata.

debug cleanup

lpriestley updated this revision to Diff 31075.May 18 2015, 10:42 PM

one more

epriestley accepted this revision.May 18 2015, 11:01 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 18 2015, 11:01 PM
Closed by commit rPec759ef46f17: Mobile day view should display event list, not day table (authored by lpriestley, committed by lpriestley). · Explain WhyMay 18 2015, 11:04 PM
This revision was automatically updated to reflect the committed changes.
chad edited edge metadata.May 18 2015, 11:14 PM

.device restricts to tablet and mobile. Maybe day view is fine on tablet?

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
phui/
calendar/
4 lines
webroot/
rsrc/
css/
phui/
calendar/
20 lines

Diff 31072

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarDayView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-day.css

Loading...
Phabricator · Built by Phacility