Differential D12912

Conpherence - fix widget updates from main view
ClosedPublic
Actions

Authored by btrahan on May 18 2015, 9:08 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T8217: Adding a participant in Conpherence causes weird layout

Commits

Restricted Diffusion Commit
rPda4617aabd3f: Conpherence - fix widget updates from main view

Summary

Fixes T8217. Broken circa D12760. Some browsers rendered nothing while others rendered a ",".

Test Plan

added folks to conpherences and saw people widget update correctly. added files to conpherence and saw file widget update correctly. Tested on Chrome and Firefox.

Diff Detail

Repository

rP Phabricator

Branch

T8217

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6084
Build 6104: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 31064.May 18 2015, 9:08 PM

btrahan added a task: T8217: Adding a participant in Conpherence causes weird layout.

btrahan retitled this revision from to Conpherence - fix widget updates from main view.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 18 2015, 9:08 PM

epriestley accepted this revision.May 18 2015, 9:09 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 18 2015, 9:09 PM

Closed by commit rPda4617aabd3f: Conpherence - fix widget updates from main view (authored by btrahan, committed by btrahan). · Explain WhyMay 18 2015, 9:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceUpdateController.php

4 lines

Diff 31064

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Conpherence - fix widget updates from main viewClosedPublicActions