Differential D12878

Never generate $0.00 invoices
ClosedPublic
Actions

Authored by epriestley on May 16 2015, 8:02 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7769: $0 invoices should be automatically payable

Commits

Restricted Diffusion Commit
rP1970ebcd7b73: Never generate $0.00 invoices

Summary

Ref T7769. It might possibly make sense to generate these some day, but for now they aren't payable and we have no use for them.

Test Plan

Generated $0.00 invoices, saw code decline to invoice.
Generated a $7.99 invoice, got an invoice.

Diff Detail

Repository

rP Phabricator

Branch

sub1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6033
Build 6053: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30969.May 16 2015, 8:02 PM

epriestley retitled this revision from to Never generate $0.00 invoices.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7769: $0 invoices should be automatically payable.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 16 2015, 8:02 PM

btrahan accepted this revision.May 18 2015, 5:14 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 18 2015, 5:14 PM

Closed by commit rP1970ebcd7b73: Never generate $0.00 invoices (authored by epriestley, committed by epriestley). · Explain WhyMay 18 2015, 5:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

worker/

PhortuneSubscriptionWorker.php

11 lines

Diff 30969

View Options

src/applications/phortune/worker/PhortuneSubscriptionWorker.php

Never generate $0.00 invoicesClosedPublicActions