Page MenuHomePhabricator

Conpherence - fix disappearing older messages bug
ClosedPublic

Authored by btrahan on May 14 2015, 6:09 PM.
Tags
None
Referenced Files
F15478637: D12844.id.diff
Tue, Apr 8, 1:29 AM
F15472799: D12844.id30893.diff
Sat, Apr 5, 4:50 PM
F15412942: D12844.diff
Wed, Mar 19, 3:55 PM
F15385817: D12844.id30894.diff
Fri, Mar 14, 11:29 PM
F15335280: D12844.id30894.diff
Mar 8 2025, 3:00 PM
F15302830: D12844.diff
Mar 5 2025, 10:39 PM
Unknown Object (File)
Feb 19 2025, 8:55 PM
Unknown Object (File)
Feb 10 2025, 2:48 PM
Subscribers

Details

Summary

Fixes T8194. If you loaded a conpherence directly via a URI like /Z1 or /conpherence/1/ we didn't correctly cache the loaded transactions such that sending a message would only show that message and subsequent messages.

Fix is to build the cache properly in this case. Note this codepath is different because the server sends back more of the thread data in the initial request.

Test Plan

loaded a conpherence directly, sent messages, paged back, everything kept showing!

Diff Detail

Repository
rP Phabricator
Branch
T8194
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5985
Build 6005: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Conpherence - fix disappearing older messages bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 14 2015, 6:13 PM
This revision was automatically updated to reflect the committed changes.