Page MenuHomePhabricator

Conpherence - make show older messages work correctly in durable column
ClosedPublic

Authored by btrahan on May 12 2015, 8:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 11:03 AM
Unknown Object (File)
Sat, Feb 8, 4:30 AM
Unknown Object (File)
Wed, Feb 5, 8:33 AM
Unknown Object (File)
Feb 3 2025, 5:04 PM
Unknown Object (File)
Feb 2 2025, 4:00 AM
Unknown Object (File)
Jan 31 2025, 3:09 PM
Unknown Object (File)
Jan 25 2025, 3:36 PM
Unknown Object (File)
Jan 25 2025, 4:10 AM
Subscribers

Details

Summary

Fixes T8009. This was basically moving the behavior from conpherence full behavior menu into the ConpherenceThreadManager so it could be re used in the durable column.

The durable column bit has no special styles - its just a link - but it seems to work well enough. I think it could be removed altogether if / when we add some automagical scrolling back into history stuff.

Test Plan

loaded up a conpherence in a durable column and used 'show older messages' successfully. loaded up a conpherence in regular view mid transaction and used show older and show newer successfully

Diff Detail

Repository
rP Phabricator
Branch
T8009
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5930
Build 5950: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Conpherence - make show older messages work correctly in durable column.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 12 2015, 9:31 PM
This revision was automatically updated to reflect the committed changes.