Page MenuHomePhabricator
Differential D12815

Calendar month view "today" indicator should be a blue bar across the bottom of the day cell
ClosedPublic
Actions

Authored by lpriestley on May 12 2015, 8:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 1:24 AM
Unknown Object (File)
Sat, Dec 14, 4:50 PM
Unknown Object (File)
Thu, Dec 12, 11:24 PM
Unknown Object (File)
Wed, Dec 4, 4:35 AM
Unknown Object (File)
Wed, Dec 4, 4:35 AM
Unknown Object (File)
Wed, Dec 4, 4:35 AM
Unknown Object (File)
Wed, Dec 4, 4:35 AM
Unknown Object (File)
Wed, Dec 4, 4:35 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4392: Implement "Month" calendar mock
Commits
Restricted Diffusion Commit
rP8e9ee8635792: Calendar month view "today" indicator should be a blue bar across the bottom…
Summary

Ref T4392, Calendar month view "today" indicator should be a blue bar across the bottom of the day cell

Test Plan

Open month view of Calendar, today should have a blue bar across the bottom of the day cell

Diff Detail

Repository
rP Phabricator
Branch
calendartodaybar
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5928
Build 5948: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30795.May 12 2015, 8:17 PM
lpriestley retitled this revision from to Calendar month view "today" indicator should be a blue bar across the bottom of the day cell.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T4392: Implement "Month" calendar mock.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptMay 12 2015, 8:17 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 30796.May 12 2015, 8:18 PM
lpriestley edited edge metadata.

Celerity map

epriestley accepted this revision.May 12 2015, 8:19 PM
epriestley edited edge metadata.
epriestley added inline comments.
webroot/rsrc/css/phui/calendar/phui-calendar-month.css
54

text-align is probably unnecessary.

Consider using a div instead of a span with display: block.

This revision is now accepted and ready to land.May 12 2015, 8:19 PM
lpriestley updated this revision to Diff 30797.May 12 2015, 8:21 PM
lpriestley edited edge metadata.

css trimming

lpriestley marked an inline comment as done.May 12 2015, 8:21 PM
Closed by commit rP8e9ee8635792: Calendar month view "today" indicator should be a blue bar across the bottom… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 12 2015, 8:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
phui/
calendar/
25 lines
webroot/
rsrc/
css/
phui/
calendar/
19 lines

Diff 30796

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-month.css

Loading...
Phabricator · Built by Phacility