Implement PHUIHeaderView from AphrontTagView
ClosedPublic
Actions

Authored by chad on May 12 2015, 3:28 AM.

Tags

None

Referenced Files

	F14043061: D12802.id30778.diff
	Tue, Nov 12, 7:28 AM

	F14042247: D12802.id30785.diff
	Tue, Nov 12, 1:42 AM

	F14037201: D12802.id30778.diff
	Sun, Nov 10, 2:21 PM

	F14020900: D12802.id30778.diff
	Wed, Nov 6, 3:34 AM

	F14012064: D12802.id30778.diff
	Fri, Nov 1, 7:10 AM

	F14009918: D12802.diff
	Thu, Oct 31, 2:03 AM

	F14004228: D12802.id30778.diff
	Sat, Oct 26, 5:15 PM

	F13995344: D12802.id.diff
	Wed, Oct 23, 12:17 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP97fbc54d0bc7: Implement PHUIHeaderView from AphrontTagView

Summary

Looking at implementing ManiphestTaskListView as standard components, need to add this functionality for Headers.

Test Plan

Browsed various pages, couldn't spot any regressions offhand.

Diff Detail

Repository

rP Phabricator

Branch

header-tag

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5912
Build 5932: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 30778.May 12 2015, 3:28 AM

chad retitled this revision from to Implement PHUIHeaderView from AphrontTagView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 12 2015, 3:28 AM

epriestley accepted this revision.May 12 2015, 11:41 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 12 2015, 11:41 AM

Closed by commit rP97fbc54d0bc7: Implement PHUIHeaderView from AphrontTagView (authored by chad, committed by chad). · Explain WhyMay 12 2015, 1:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

view/

phui/

PHUIHeaderView.php

42 lines

Diff 30778

View Options

src/__phutil_library_map__.php