Page MenuHomePhabricator

Don't trim remarkup corpora before summarizing
ClosedPublic

Authored by epriestley on May 11 2015, 3:30 PM.
Tags
None
Referenced Files
F13996984: D12794.id.diff
Thu, Oct 24, 1:31 AM
Unknown Object (File)
Oct 8 2024, 9:59 AM
Unknown Object (File)
Oct 2 2024, 5:05 AM
Unknown Object (File)
Sep 21 2024, 2:10 PM
Unknown Object (File)
Sep 1 2024, 3:10 PM
Unknown Object (File)
Aug 26 2024, 10:00 PM
Unknown Object (File)
Aug 19 2024, 2:25 PM
Unknown Object (File)
Aug 18 2024, 4:56 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP75fc4e763ad6: Don't trim remarkup corpora before summarizing
Summary

Currently, lists like this:

- a
- b
- c

...get trimmed before summarization and end up looking like this after summarization:

- a
  - b
  - c

This produces the summary artifacts (first item at wrong indent level):

Screen Shot 2015-05-11 at 8.29.34 AM.png (238×686 px, 30 KB)

Instead, don't trim. This produces better summaries.

Test Plan

Saw a better summary of a list.

Diff Detail

Repository
rP Phabricator
Branch
feedtrim
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5895
Build 5915: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Don't trim remarkup corpora before summarizing.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 11 2015, 6:10 PM
This revision was automatically updated to reflect the committed changes.