Page MenuHomePhabricator
Differential D12793

Use full URIs to link to objects from Phame blogs
ClosedPublic
Actions

Authored by epriestley on May 11 2015, 2:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 10:16 AM
Unknown Object (File)
Sat, Feb 8, 4:27 AM
Unknown Object (File)
Sat, Feb 8, 4:27 AM
Unknown Object (File)
Thu, Jan 30, 5:27 AM
Unknown Object (File)
Wed, Jan 29, 10:29 AM
Unknown Object (File)
Fri, Jan 24, 4:20 AM
Unknown Object (File)
Fri, Jan 24, 4:20 AM
Unknown Object (File)
Jan 22 2025, 3:52 AM
View All Files
Subscribers
epriestley
johnny-bit

Details

Reviewers
btrahan
Maniphest Tasks
T6299: Remarkup links to objects in Phame break if a CNAME is set
Commits
Restricted Diffusion Commit
rP3df64104de20: Use full URIs to link to objects from Phame blogs
Summary

Fixes T6299.

Test Plan

Viewed live blog, saw full URIs.

Diff Detail

Repository
rP Phabricator
Branch
phamelink
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5893
Build 5913: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30752.May 11 2015, 2:15 PM
epriestley retitled this revision from to Use full URIs to link to objects from Phame blogs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6299: Remarkup links to objects in Phame break if a CNAME is set.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 11 2015, 2:15 PM
epriestley mentioned this in T6299: Remarkup links to objects in Phame break if a CNAME is set.May 11 2015, 2:17 PM
johnny-bit added a subscriber: johnny-bit.May 11 2015, 5:17 PM
btrahan accepted this revision.May 11 2015, 6:09 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 11 2015, 6:09 PM
Closed by commit rP3df64104de20: Use full URIs to link to objects from Phame blogs (authored by epriestley, committed by epriestley). · Explain WhyMay 11 2015, 6:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
pholio/
remarkup/
4 lines
infrastructure/
markup/
7 lines
rule/
8 lines

Diff 30752

View Options

src/applications/pholio/remarkup/PholioRemarkupRule.php

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php

Loading...
Phabricator · Built by Phacility