Page MenuHomePhabricator
Differential D12787

Calendar month view should notify user if all or part of the month was not included in the query search
ClosedPublic
Actions

Authored by lpriestley on May 10 2015, 2:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 4:20 PM
Unknown Object (File)
Fri, Dec 20, 10:02 AM
Unknown Object (File)
Sat, Dec 14, 1:30 PM
Unknown Object (File)
Sat, Dec 14, 3:51 AM
Unknown Object (File)
Wed, Dec 11, 5:03 AM
Unknown Object (File)
Sat, Nov 30, 10:25 AM
Unknown Object (File)
Fri, Nov 29, 1:12 AM
Unknown Object (File)
Mon, Nov 25, 8:35 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8104: Viewer should be notified if viewed "day view" or "month view" is out of the selected query range.
Commits
Restricted Diffusion Commit
rPf7662d61ac6b: Calendar month view should notify user if all or part of the month was not…
Summary

Closes T8104, Calendar month view should notify user if all or part of the month was not included in the query search

Test Plan

In Calendar month view, search May 1-13, get "part of month is out of range", search May 1-31, 12am - 11:59:59, get no errors.

Diff Detail

Repository
rP Phabricator
Branch
calendarmonthqueryoutofrange
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5885
Build 5905: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30738.May 10 2015, 2:09 AM
lpriestley retitled this revision from to Calendar month view should notify user if all or part of the month was not included in the query search.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8104: Viewer should be notified if viewed "day view" or "month view" is out of the selected query range. .
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 10 2015, 2:09 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 10 2015, 2:10 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 10 2015, 2:10 AM
Closed by commit rPf7662d61ac6b: Calendar month view should notify user if all or part of the month was not… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 10 2015, 2:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
query/
4 lines
view/
phui/
calendar/
53 lines
49 lines

Diff 30738

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarDayView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
Phabricator · Built by Phacility