Page MenuHomePhabricator
Differential D12781

Trim transaction overload when converting events from all-day and back
ClosedPublic
Actions

Authored by lpriestley on May 8 2015, 11:40 PM.
Tags
None
Referenced Files
F14837157: D12781.diff
Fri, Jan 31, 7:20 AM
Unknown Object (File)
Wed, Jan 29, 2:56 AM
Unknown Object (File)
Fri, Jan 24, 9:18 PM
Unknown Object (File)
Fri, Jan 24, 2:26 PM
Unknown Object (File)
Tue, Jan 21, 11:04 AM
Unknown Object (File)
Tue, Jan 14, 7:22 AM
Unknown Object (File)
Sat, Jan 11, 4:18 AM
Unknown Object (File)
Dec 22 2024, 4:48 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8136: Extra transactions for "converting from all day event"
Commits
Restricted Diffusion Commit
rPdd8e4ff056af: Trim transaction overload when converting events from all-day and back
Summary

Closes T8136, Trim transaction overload when converting events from all-day and back

Test Plan

Create new event, save, edit, change to all-day, save, remove all-day flag, save. Feed should not show "end date changed" transaction

Diff Detail

Repository
rP Phabricator
Branch
calendartransactionoverload
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5874
Build 5894: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30723.May 8 2015, 11:40 PM
lpriestley retitled this revision from to Trim transaction overload when converting events from all-day and back.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8136: Extra transactions for "converting from all day event".
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 8 2015, 11:40 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 8 2015, 11:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 8 2015, 11:41 PM
Closed by commit rPdd8e4ff056af: Trim transaction overload when converting events from all-day and back (authored by lpriestley, committed by lpriestley). · Explain WhyMay 9 2015, 12:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
editor/
5 lines
storage/
2 lines

Diff 30723

View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
Phabricator · Built by Phacility